This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Fix parsing of batch headers #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
useless private function, it just can be array_column($response['headers'], 'value', 'name') ;)
Contributor
Author
There was a problem hiding this comment.
You and your efficient ways. :) Since array_column() is a PHP 5.5 feature, we'll need to wait to add this until PHP SDK v6.0 (which I'm assuming will require PHP 5.5.) :)
Contributor
There was a problem hiding this comment.
You're right!! My bad, I forgot that we support 5.4 in v5
Contributor
There was a problem hiding this comment.
About v6.0, it can even require at least 5.6 :D
Contributor
Author
There was a problem hiding this comment.
I like the way you think. :)
Contributor
|
👍 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #521. :)