This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Use Composer safe versions #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Contributor
|
@EmanueleMinotto you might have to close and open this again to get the build to run again. It errored out for some reason. :) |
Contributor
|
Going to re-open to trigger the tests again. :) |
Contributor
|
Hey @EmanueleMinotto! Do you mind fixing the merge conflicts in this so we can merge? :) |
EmanueleMinotto
force-pushed
the
composer-best-practice
branch
from
f83de97 to
6727ffa
Compare
Contributor
Author
|
done :) |
Contributor
|
That was fast - thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range operator isn't considered "safe" by Composer (ref), so a switch to the caret operator is suggested.
Also the PHP 7 build ends with success, so imo it should be kept as a requirement also on TravisCI.