Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Conversation

@SammyK
Copy link
Contributor

@SammyK SammyK commented Feb 11, 2016

Fixes #532

Facebook app ID's are really big and on 32-bit systems many are bigger than PHP_INT_MAX causing integer overflow issues. We can't fix when people overflow an int:

$appId = PHP_INT_MAX + 10;

But we can at least give them better error messages and prevent overflows when FacebookApp is unserialized. :)

@SammyK
Copy link
Contributor Author

SammyK commented Apr 7, 2016

@gfosco This bug fix is also ready to go. :)

@SammyK SammyK added this to the 5.2.0 milestone May 18, 2016
@SammyK SammyK merged commit bbcae90 into facebookarchive:master May 18, 2016
@SammyK SammyK deleted the app-ids-as-string branch May 18, 2016 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants