Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Conversation

@SammyK
Copy link
Contributor

@SammyK SammyK commented Apr 12, 2016

Graph v2.6 is the new hotness. :)

@yguedidi
Copy link
Contributor

@SammyK you know this is a BC break in fact? ;)

@SammyK
Copy link
Contributor Author

SammyK commented Apr 13, 2016

Yes, for those who are using the default fall-back version of Graph. That's why I wanted the next version of the SDK to throw an exception if you don't provide a default Graph version. But in the docs all the examples have the Graph version in the options array so for the copy-pasters, they'll have their Graph version set.

So yeah, it's BC for a very small subset, but I feel like we decided to keep bumping the Graph version every time a new one came out. But I'm cool with just keeping v2.5 for the default fallback in Facebook and just updating the docs to v2.6. Then the developers who are using the fall-back option will get upgraded to the next version of Graph when v2.5 is force-upgraded on April 12, 2018.

What do you guys think?

@yguedidi
Copy link
Contributor

That's why I wanted the next version of the SDK to throw an exception if you don't provide a default Graph version.

Me too!

I feel like we decided to keep bumping the Graph version every time a new one came out.

You're right, I'm not really against this change as we used to do it in the 5.x major version. I said it more like a reminder for 6.x

@gfosco
Copy link
Contributor

gfosco commented Apr 19, 2016

@SammyK @yguedidi You're now core collaborators with write privileges. Wield your powers responsibly and for great justice. 🎉

@SammyK
Copy link
Contributor Author

SammyK commented Apr 19, 2016

You the man @gfosco! :)

@SammyK SammyK added this to the 5.2.0 milestone May 18, 2016
@SammyK SammyK merged commit ea65829 into facebookarchive:master May 18, 2016
@SammyK SammyK deleted the graph-v2.6 branch May 18, 2016 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants