This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Implementing new Birthday class to handle Graph API response variations #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/Birthday.fbmd
Outdated
| ~~~~ | ||
| $fb = new Facebook\Facebook(\* *\); | ||
| // Returns a `Facebook\FacebookResponse` object | ||
| $response = $fb->get('/something'); |
Contributor
There was a problem hiding this comment.
As it's about a user, I'd get /me :)
src/Facebook/GraphNodes/Birthday.php
Outdated
| { | ||
| $parts = explode('/', $date); | ||
|
|
||
| if (count($parts) === 3 || count($parts) === 1) { |
Contributor
There was a problem hiding this comment.
ifs are useless, you can just $this->hasYear = count($parts) === 3 || count($parts) === 1, same below with hasDate.
Contributor
|
@nickma42 Thanks for your contribution! |
Contributor
Author
|
Thanks for your help in the ticket too! You guys are very helpful and responsive :) |
docs/sdk_reference.fbmd
Outdated
| 'A collection that represents a User node.', | ||
| ], | ||
| [ | ||
| '[`Facebook\\GraphNodes\\Birthday`](/docs/php/Birthday#instance-methods)', |
Contributor
There was a problem hiding this comment.
I don't think it should be listed here, ping @SammyK
Contributor
There was a problem hiding this comment.
I agree. I think I'd modify the docs on GraphNode and edit the lines that talk about the return type and link to the Birthday documentation from there. :)
Contributor
|
Looks good to me, 👍 |
src/Facebook/GraphNodes/Birthday.php
Outdated
| /** | ||
| * @var bool | ||
| */ | ||
| protected $hasDate = false; |
…ore appropriate location
Contributor
Author
|
Thanks guys - much appreciated :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #570 since the Graph API can return the birthday field as either mm/dd/yyyy, mm/dd or yyyy.