Conversation
|
Hi @mlch911! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-syntax.git", from: "600.0.0") | ||
| .package(url: "https://github.com/apple/swift-syntax.git", from: "602.0.0"), |
There was a problem hiding this comment.
The version was dropped from 600 to 602 in the pervious pull request https://github.com/facebookincubator/QuickLayout/pull/3/files from @JonyFang.
What features do you need from 602 to support for this pull request?
There was a problem hiding this comment.
No, I don't need 602.
But the pervious PR is broader compatibility, I think this version does not effect compatibility.
There was a problem hiding this comment.
Let's avoid making changes that aren't required to achieve your goal of running tests. Could you please revert it to 600?
There was a problem hiding this comment.
Let's avoid making changes that aren't required to achieve your goal of running tests. Could you please revert it to 600?
Done.
|
@constantine-fry has imported this pull request. If you are a Meta employee, you can view this in D88258295. |
|
Where did the Linter fail? @constantine-fry |
|
@mlch911 could you please apply linter.patch to your pull request. Thank you. |
There are many unknown path in the patch file |
Done |
|
@constantine-fry merged this pull request in 1dfb89f. |
3 participants
Be able to run test. #2