Capture expect step output for check verification (#609)#609
Closed
isaac-fletcher wants to merge 2 commits intofacebookincubator:mainfrom
Closed
Capture expect step output for check verification (#609)#609isaac-fletcher wants to merge 2 commits intofacebookincubator:mainfrom
isaac-fletcher wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
isaac-fletcher
requested review from
CrimsonK1ng,
RoboticPrism,
d0n601 and
d3sch41n
as code owners
|
@isaac-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97167049. |
isaac-fletcher
added a commit
to isaac-fletcher/TTPForge
that referenced
this pull request
Mar 20, 2026
) Summary: Add capability to the expect block to capture output for usage in checks. Previously, any output from expect was redirected to stdout and not captured. This change enables you to reference expect step output with the `$forge.steps.<name>.stdout` or in an output check block. Additionally cleaned up the output from the error case where it will no longer output the whole step output. Reviewed By: RoboticPrism Differential Revision: D97167049
meta-codesync
bot
changed the title
isaac-fletcher
force-pushed
the
export-D97167049
branch
from
3b13582 to
f401ef7
Compare
…ubator#610) Summary: Update check block to default to local as opposed to inheriting from the step. Remote block is an explicit requirement for running commands remotely. This change is to match the overal format of the other steps in remote. Reviewed By: RoboticPrism Differential Revision: D97167047
) Summary: Add capability to the expect block to capture output for usage in checks. Previously, any output from expect was redirected to stdout and not captured. This change enables you to reference expect step output with the `$forge.steps.<name>.stdout` or in an output check block. Additionally cleaned up the output from the error case where it will no longer output the whole step output. Reviewed By: RoboticPrism Differential Revision: D97167049
isaac-fletcher
force-pushed
the
export-D97167049
branch
from
f401ef7 to
c9e2b23
Compare
|
This pull request has been merged in 8ad1fdd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add capability to the expect block to capture output for usage in checks.
Previously, any output from expect was redirected to stdout and not captured. This change enables you to reference expect step output with the
$forge.steps.<name>.stdoutor in an output check block.Additionally cleaned up the output from the error case where it will no longer output the whole step output.
Reviewed By: RoboticPrism
Differential Revision: D97167049