refactor: Enforce callers to provide metadataIoStats to TabletReader (#731)#731
Closed
duxiao1212 wants to merge 1 commit into
Closed
refactor: Enforce callers to provide metadataIoStats to TabletReader (#731)#731duxiao1212 wants to merge 1 commit into
duxiao1212 wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@duxiao1212 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105338687. |
duxiao1212
changed the title
meta-codesync
Bot
changed the title
duxiao1212
force-pushed
the
export-D105338687
branch
from
a16c977 to
65fccd5
Compare
duxiao1212
changed the title
…ncubator#731) Summary: X-link: facebookincubator/velox#17534 Remove the `defaultIoStats_` fallback in `TabletReader` and instead enforce that callers always supply `ioOptions` with a non-null `metadataIoStats()`. The constructor now does an early `NIMBLE_CHECK` / `NIMBLE_CHECK_NOT_NULL` in its init list, so any caller that forgets to set the field fails fast at construction with a clear message. Reviewed By: xiaoxmeng Differential Revision: D105338687
meta-codesync
Bot
changed the title
duxiao1212
force-pushed
the
export-D105338687
branch
from
65fccd5 to
ff9b94c
Compare
duxiao1212
added a commit
to duxiao1212/velox
that referenced
this pull request
May 15, 2026
…ncubator#17534) Summary: X-link: facebookincubator/nimble#731 Remove the `defaultIoStats_` fallback in `TabletReader` and instead enforce that callers always supply `ioOptions` with a non-null `metadataIoStats()`. The constructor now does an early `NIMBLE_CHECK` / `NIMBLE_CHECK_NOT_NULL` in its init list, so any caller that forgets to set the field fails fast at construction with a clear message. Reviewed By: xiaoxmeng Differential Revision: D105338687
duxiao1212
changed the title
xiaoxmeng
approved these changes
May 15, 2026
|
This pull request has been merged in 0c4ca07. |
meta-codesync Bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
May 16, 2026
…17534) Summary: Pull Request resolved: #17534 X-link: facebookincubator/nimble#731 Remove the `defaultIoStats_` fallback in `TabletReader` and instead enforce that callers always supply `ioOptions` with a non-null `metadataIoStats()`. The constructor now does an early `NIMBLE_CHECK` / `NIMBLE_CHECK_NOT_NULL` in its init list, so any caller that forgets to set the field fails fast at construction with a clear message. Reviewed By: xiaoxmeng Differential Revision: D105338687 fbshipit-source-id: 53d2b708ea5ea96c4ca27dc4b50b4d7720e0afa8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#17534
Remove the
defaultIoStats_fallback inTabletReaderand instead enforce that callers always supplyioOptionswith a non-nullmetadataIoStats(). The constructor now does an earlyNIMBLE_CHECK/NIMBLE_CHECK_NOT_NULLin its init list, so any caller that forgets to set the field fails fast at construction with a clear message.Reviewed By: xiaoxmeng
Differential Revision: D105338687