refactor(encoding): Move encoding selection files to selection/ subfolder (#741)#741
Closed
srsuryadev wants to merge 1 commit into
Closed
refactor(encoding): Move encoding selection files to selection/ subfolder (#741)#741srsuryadev wants to merge 1 commit into
selection/ subfolder (#741)#741srsuryadev wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@srsuryadev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105446634. |
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Differential Revision: D105446634
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
srsuryadev
added a commit
to srsuryadev/velox
that referenced
this pull request
May 17, 2026
…folder (facebookincubator#17540) Summary: Pull Request resolved: facebookincubator#17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
…folder (facebookincubator#741) Summary: X-link: facebookincubator/velox#17540 Pull Request resolved: facebookincubator#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634
meta-codesync
Bot
changed the title
selection/ subfolderselection/ subfolder (#741)
srsuryadev
force-pushed
the
export-D105446634
branch
from
6c3df6b to
c29cd40
Compare
meta-codesync Bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
May 17, 2026
…folder (#17540) Summary: Pull Request resolved: #17540 X-link: facebookincubator/nimble#741 Moves encoding selection files (`EncodingSelection.h`, `EncodingSelectionPolicy.h`, `EncodingSizeEstimation.h`, `Statistics.h/.cpp`, `EncodingIdentifier.h`) into a new `encodings/selection/` subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure between `EncodingSelection.h` and `EncodingFactory.h`. All include paths across ~55 consumer files are updated accordingly. Reviewed By: pratikpugalia Differential Revision: D105446634 fbshipit-source-id: d5665c130c8118dbe0da1f633b14546f6cb9403f
|
This pull request has been merged in 772521d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#17540
Moves encoding selection files (
EncodingSelection.h,EncodingSelectionPolicy.h,EncodingSizeEstimation.h,Statistics.h/.cpp,EncodingIdentifier.h) into a newencodings/selection/subfolder for better code organization. The files remain in the same BUCK target to preserve the existing dependency structure betweenEncodingSelection.handEncodingFactory.h. All include paths across ~55 consumer files are updated accordingly.Reviewed By: pratikpugalia
Differential Revision: D105446634