Add health checks and fix IPv6 parsing in cdn_bench#575
Open
SamirFarhat17 wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Add health checks and fix IPv6 parsing in cdn_bench#575SamirFarhat17 wants to merge 1 commit intofacebookresearch:v2-betafrom
SamirFarhat17 wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
Summary:
Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving:
- verify_content_server() probes each content_server with curl after startup to confirm it's actually serving, not just listening
- Backend Reachability Check runs before starting proxies — if any backend is unreachable it prints the exact curl command to debug and aborts
- Fixed IPv6 host:port parsing (was using ${entry%:*} which strips everything after the first colon, now extracts port first then strips it)
Differential Revision: D100220256
meta-cla
bot
added
the
CLA Signed
|
@SamirFarhat17 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100220256. |
SamirFarhat17
added a commit
to SamirFarhat17/DCPerf
that referenced
this pull request
Apr 13, 2026
…#575) Summary: Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving: - verify_content_server() probes each content_server with curl after startup to confirm it's actually serving, not just listening - Backend Reachability Check runs before starting proxies — if any backend is unreachable it prints the exact curl command to debug and aborts - Fixed IPv6 host:port parsing (was using ${entry%:*} which strips everything after the first colon, now extracts port first then strips it) Differential Revision: D100220256
SamirFarhat17
added a commit
to SamirFarhat17/DCPerf
that referenced
this pull request
Apr 13, 2026
…#575) Summary: Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving: - verify_content_server() probes each content_server with curl after startup to confirm it's actually serving, not just listening - Backend Reachability Check runs before starting proxies — if any backend is unreachable it prints the exact curl command to debug and aborts - Fixed IPv6 host:port parsing (was using ${entry%:*} which strips everything after the first colon, now extracts port first then strips it) Reviewed By: YifanYuan3 Differential Revision: D100220256
SamirFarhat17
pushed a commit
to SamirFarhat17/DCPerf
that referenced
this pull request
Apr 13, 2026
…#575) Summary: Pull Request resolved: facebookresearch#575 Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving: - verify_content_server() probes each content_server with curl after startup to confirm it's actually serving, not just listening - Backend Reachability Check runs before starting proxies — if any backend is unreachable it prints the exact curl command to debug and aborts - Fixed IPv6 host:port parsing (was using ${entry%:*} which strips everything after the first colon, now extracts port first then strips it) Differential Revision: D100220256
SamirFarhat17
added a commit
to SamirFarhat17/DCPerf
that referenced
this pull request
Apr 13, 2026
…#575) Summary: Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving: - verify_content_server() probes each content_server with curl after startup to confirm it's actually serving, not just listening - Backend Reachability Check runs before starting proxies — if any backend is unreachable it prints the exact curl command to debug and aborts - Fixed IPv6 host:port parsing (was using ${entry%:*} which strips everything after the first colon, now extracts port first then strips it) Reviewed By: YifanYuan3 Differential Revision: D100220256
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
Summary: Pull Request resolved: #575 Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving: - verify_content_server() probes each content_server with curl after startup to confirm it's actually serving, not just listening - Backend Reachability Check runs before starting proxies — if any backend is unreachable it prints the exact curl command to debug and aborts - Fixed IPv6 host:port parsing (was using ${entry%:*} which strips everything after the first colon, now extracts port first then strips it) Reviewed By: YifanYuan3 Differential Revision: D100220256 fbshipit-source-id: 4a9cd6c1c8b7d536390b7c930110109461b53b1b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added health checks to cdn_bench/run.sh so it fails fast with a clear message instead of silently misbehaving:
Differential Revision: D100220256