This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
JackUrb
approved these changes
Apr 29, 2021
Contributor
JackUrb
left a comment
JackUrb
left a comment
There was a problem hiding this comment.
Thanks for the fixes Justin! We're running out of things to fix before launch haha
Comment on lines
+164
to
+189
| {actor ? ( | ||
| <div className="agent"> | ||
| <span style={{ fontFamily: "fantasy" }}> | ||
| {actor ? actor.toUpperCase() : null} | ||
| </span> | ||
| {isSelf ? ( | ||
| <React.Fragment> | ||
| {xp ? ( | ||
| <> | ||
| <span | ||
| style={{ | ||
| fontFamily: "fantasy", | ||
| backgroundColor: "white", | ||
| color: "gold", | ||
| }} | ||
| > | ||
| {xp} | ||
| <i | ||
| className="fa fa-star" | ||
| style={{ color: "gold", marginLeft: "5px" }} | ||
| /> | ||
| </span> | ||
| </> | ||
| ) : null} | ||
| </React.Fragment> | ||
| ) : ( |
Contributor
There was a problem hiding this comment.
These nested ternary operators are beginning to be hard to navigate and understand what's actually rendering here just from a glance. I tend to prefer setting subcomponents outside of the main flow at this level of depth, but there are certainly cases where the ternary operator is the right choice.
Not blocking, just musings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES
IN PROGRESS