This repository was archived by the owner on Oct 11, 2023. It is now read-only.
added Character header to soulspawn event#212
Merged
JustinPinero merged 2 commits intopre-alpha-fixes3from May 4, 2021
Merged
Conversation
Contributor
JustinPinero
commented
May 3, 2021
JustinPinero
commented
- Added Character header to soul spawn event.
facebook-github-bot
added
the
CLA Signed
JackUrb
approved these changes
May 4, 2021
Contributor
JackUrb
left a comment
JackUrb
left a comment
There was a problem hiding this comment.
Seems alright to me! One nit on cleanliness.
Comment on lines
+36
to
+40
| textDecoration: "underline", | ||
| marginBottom: "0", | ||
| fontFamily: "fantasy", | ||
| fontWeight: "900", | ||
| fontSize: "18px", |
Contributor
There was a problem hiding this comment.
This is duplicated between YOUR CHARACTER and YOUR MISSION, and should probably be in a CSS file.
Contributor
Author
There was a problem hiding this comment.
I will put that in a css file now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.