This repository was archived by the owner on Aug 6, 2025. It is now read-only.
pad image at inference time, remove resize #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mmuckley
approved these changes
Dec 2, 2022
Contributor
mmuckley
left a comment
mmuckley
left a comment
There was a problem hiding this comment.
LGTM. Thanks for finding this!
Contributor
|
@desi-ivanova could you fix the failed tests? Then I can merge. |
where appropriate in tests
Contributor
Author
|
@mmuckley let me know if there's anything blocking the merge |
Contributor
|
@desi-ivanova looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
At inference time, pad the image instead of doing an interpolation-based resize, which gives poor results (e.g. on PSNR) when the input image heigh and/or width is not exactly divisible by the downsampling factor (
=2^{number of downsampling layers}).