LIA use one-sided CI upper-bound (#129)#129
Closed
hjungwitai wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@hjungwitai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104239997. |
Summary: * Added a choice between one-sided CI upper bound and two-sided upper bound in computing epsilons * Minor changes in `AnalysisNode._compute_ci()` with a related change in `FactoredLiAAnalysisNode.merge_results()` * Controlled by a new arg `use_one_sided_ci_ub` (default False; that is, the default is the same as before, two-sided) Reviewed By: knottb Differential Revision: D104239997
meta-codesync
Bot
changed the title
hjungwitai
force-pushed
the
export-D104239997
branch
from
c783abe to
5d364f6
Compare
|
This pull request has been merged in fb9c26c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
AnalysisNode._compute_ci()with a related change inFactoredLiAAnalysisNode.merge_results()use_one_sided_ci_ub(default False; that is, the default is the same as before, two-sided)Reviewed By: knottb
Differential Revision: D104239997