This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Include docs and other text files in source distribution#105
Closed
lw wants to merge 1 commit intofacebookresearch:masterfrom
Closed
Include docs and other text files in source distribution#105lw wants to merge 1 commit intofacebookresearch:masterfrom
lw wants to merge 1 commit intofacebookresearch:masterfrom
Conversation
Make the source distribution match the GitHub repo, except for "metadata" files related to our "infrastructure" (.gitignore, .github/, .circleci/). Fixes facebookresearch#103, although it doesn't exactly fix the issue there because we've gotten rid of the requirements.txt file a while ago (including its contents in setup.cfg) and that issue has already disappeared.
facebook-github-bot
added
the
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@lerks has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the source distribution match the GitHub repo, except for "metadata" files related to our "infrastructure" (.gitignore, .github/, .circleci/).
Fixes #103, although it doesn't exactly fix the issue there because we've gotten rid of the requirements.txt file a while ago (including its contents in setup.cfg) and that issue has already disappeared.
Types of changes
Motivation and Context / Related issue
See #103.
How Has This Been Tested (if it applies)
I ran
./setup.py sdistand inspected the tar.gz.