Write end-to-end workflow with new open-sourced workflow code#237

Closed

kaiwenw wants to merge 1 commit into

facebookresearch:masterfrom

kaiwenw:e2e-workflow

Contributor

kaiwenw commented Apr 21, 2020 •

edited

Loading

Use refactored gymrunner for making data batch
Implement train_and_evaluate_generic
(partially) fill out discrete_dqn_reporter
fill out model_manager.train_workflow
replace test_oss_workflow.py with new test.
simplify Preprocessor.scala and remove unused params in Timeline.scala

kaiwenw force-pushed the e2e-workflow branch 4 times, most recently from 44eef59 to 57dc402 Compare

April 22, 2020 18:11

facebook-github-bot reviewed

View reviewed changes

facebook-github-bot left a comment

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot reviewed

View reviewed changes

facebook-github-bot left a comment

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kaiwenw force-pushed the e2e-workflow branch 2 times, most recently from 74716ed to 48755e7 Compare

April 22, 2020 21:58

codecov-io commented Apr 22, 2020 •

edited

Loading

Codecov Report

Merging #237 into master will increase coverage by 0.93%.
The diff coverage is 82.16%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   84.02%   84.95%   +0.93%     
==========================================
  Files         193      210      +17     
  Lines       14050    14242     +192     
  Branches       52       42      -10     
==========================================
+ Hits        11805    12099     +294     
+ Misses       2221     2119     -102     
  Partials       24       24

Impacted Files	Coverage Δ
...cala/com/facebook/spark/rl/MultiStepTimeline.scala	`92.98% <ø> (-0.36%)`	⬇️
...rc/main/scala/com/facebook/spark/rl/Timeline.scala	`86.90% <0.00%> (-3.40%)`	⬇️
reagent/gym/policies/samplers/discrete_sampler.py	`39.13% <0.00%> (ø)`
reagent/gym/runners/gymrunner.py	`94.44% <ø> (ø)`
reagent/gym/types.py	`85.71% <ø> (ø)`
...t/workflow/model_managers/discrete/discrete_dqn.py	`100.00% <ø> (ø)`
...agent/workflow/model_managers/discrete_dqn_base.py	`100.00% <ø> (ø)`
reagent/gym/policies/random_policies.py	`34.04% <31.03%> (ø)`
reagent/gym/agents/post_step.py	`70.17% <33.33%> (ø)`
reagent/workflow/gym_batch_rl.py	`70.51% <70.51%> (ø)`
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de10f79...cb499ce. Read the comment docs.

facebook-github-bot reviewed

View reviewed changes

facebook-github-bot left a comment

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kaiwenw force-pushed the e2e-workflow branch 3 times, most recently from 712474c to 68eecdd Compare

April 23, 2020 23:17

facebook-github-bot reviewed

View reviewed changes

facebook-github-bot left a comment

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kaiwenw force-pushed the e2e-workflow branch from dbfc811 to 571e7a3 Compare

April 24, 2020 03:55

facebook-github-bot reviewed

View reviewed changes

facebook-github-bot left a comment

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

8869b05

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Differential Revision: D21181946

fbshipit-source-id: 496ea387aed3b3be6f8bff18194b01440119b848

kaiwenw force-pushed the e2e-workflow branch from 571e7a3 to 8869b05 Compare

April 24, 2020 21:22

facebook-github-bot commented Apr 24, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

41d4740

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Differential Revision: D21181946

fbshipit-source-id: 595545618cbdcdfb9fc960ed1fa27f0f168c8794

kaiwenw force-pushed the e2e-workflow branch from 8869b05 to 41d4740 Compare

April 24, 2020 22:48

facebook-github-bot commented Apr 24, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

8ebcbc3

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Differential Revision: D21181946

fbshipit-source-id: 2ee53b1251241e75f172b0d6a37f16c9b4733b91

kaiwenw force-pushed the e2e-workflow branch from 41d4740 to 8ebcbc3 Compare

April 24, 2020 22:51

facebook-github-bot commented Apr 24, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

33ce588

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Differential Revision: D21181946

fbshipit-source-id: 7a7f819945662afc683432b8707ad4ccf4bc9162

kaiwenw force-pushed the e2e-workflow branch from 8ebcbc3 to 33ce588 Compare

April 24, 2020 23:18

facebook-github-bot commented Apr 24, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

58927a1

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Differential Revision: D21181946

fbshipit-source-id: 06f073e933109116a4b63bc48451a0b065218da7

kaiwenw force-pushed the e2e-workflow branch from 33ce588 to 58927a1 Compare

April 24, 2020 23:39

facebook-github-bot commented Apr 24, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

cbfce41

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Test Plan: Run workflow in scripts/ci/run_end_to_end_test.sh.

Reviewed By: kittipatv

Differential Revision: D21181946

Pulled By: kittipatv

fbshipit-source-id: 1435bf31e75186bd179bf379410d9c6f8ad324f6

kaiwenw force-pushed the e2e-workflow branch from 58927a1 to cbfce41 Compare

April 25, 2020 00:44

facebook-github-bot commented Apr 25, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request


          Write end-to-end workflow with new open-sourced workflow code (facebo…

5772efc

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Test Plan: Run workflow in scripts/ci/run_end_to_end_test.sh.

Reviewed By: kittipatv

Differential Revision: D21181946

Pulled By: kittipatv

fbshipit-source-id: 57a10e64c597fd402d8052a10d726d0eae42a7d9

kaiwenw force-pushed the e2e-workflow branch from cbfce41 to 5772efc Compare

April 25, 2020 01:31

facebook-github-bot commented Apr 25, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946


          Write end-to-end workflow with new open-sourced workflow code (facebo…

cb499ce

…okresearch#237)

Summary:
- Use refactored gymrunner for making data batch
- Implement train_and_evaluate_generic
- (partially) fill out discrete_dqn_reporter
- fill out model_manager.train_workflow
- replace test_oss_workflow.py with new test.
- simplify Preprocessor.scala and remove unused params in Timeline.scala
Pull Request resolved: facebookresearch#237

Test Plan: Run workflow in scripts/ci/run_end_to_end_test.sh.

Reviewed By: kittipatv

Differential Revision: D21181946

Pulled By: kittipatv

fbshipit-source-id: b82e1f38aa600477138e6aadea72b5fa5bce9c4c

kaiwenw force-pushed the e2e-workflow branch from 5772efc to cb499ce Compare

April 25, 2020 03:54

facebook-github-bot commented Apr 25, 2020

This pull request was exported from Phabricator. Differential Revision: D21181946

facebook-github-bot closed this in

e7c7b26

kaiwenw deleted the e2e-workflow branch

April 25, 2020 05:56

facebook-github-bot commented Apr 25, 2020

@kaiwenw merged this pull request in e7c7b26.

facebook-github-bot added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels