Skip to content

add sac to circle ci#255

Closed
kaiwenw wants to merge 1 commit into
facebookresearch:masterfrom
kaiwenw:sac-circleci
Closed

add sac to circle ci#255
kaiwenw wants to merge 1 commit into
facebookresearch:masterfrom
kaiwenw:sac-circleci

Conversation

@kaiwenw
Copy link
Copy Markdown
Contributor

@kaiwenw kaiwenw commented May 6, 2020

No description provided.

@kaiwenw kaiwenw force-pushed the sac-circleci branch 7 times, most recently from 46534f2 to 799da58 Compare May 6, 2020 23:37
Copy link
Copy Markdown

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request May 7, 2020
Summary: Pull Request resolved: facebookresearch#255

Differential Revision: D21440433

Pulled By: kaiwenw

fbshipit-source-id: ccd39ff7f3ada1ba6d8f922de56fc07a882e78fc
kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request May 7, 2020
Summary: Pull Request resolved: facebookresearch#255

Differential Revision: D21440433

Pulled By: kaiwenw

fbshipit-source-id: 4a3b3b17db902508cebc6823eef81305f4932772
Copy link
Copy Markdown

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Copy Markdown

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 7, 2020

Codecov Report

Merging #255 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files         225      225           
  Lines       14546    14547    +1     
  Branches       42       42           
=======================================
+ Hits        12211    12212    +1     
  Misses       2311     2311           
  Partials       24       24           
Impacted Files Coverage Δ
reagent/gym/policies/random_policies.py 56.66% <40.00%> (+0.73%) ⬆️
reagent/workflow/gym_batch_rl.py 66.66% <50.00%> (ø)
reagent/gym/tests/test_gym.py 98.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5d315...bd54fd5. Read the comment docs.

kaiwenw added a commit to kaiwenw/ReAgent that referenced this pull request May 8, 2020
Summary: Pull Request resolved: facebookresearch#255

Differential Revision: D21440433

Pulled By: kaiwenw

fbshipit-source-id: b7f0da09963674d080668e5de623c77b49b1ca3d
@facebook-github-bot
Copy link
Copy Markdown

@kaiwenw merged this pull request in 2d824a7.

@kaiwenw kaiwenw deleted the sac-circleci branch May 8, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants