Separate unittest to two and add code coverage for e2e#261
Closed
kaiwenw wants to merge 1 commit into
Closed
Conversation
kaiwenw
changed the title
kaiwenw
force-pushed
the
separate_unittest
branch
17 times, most recently
from
e55037b to
5a1c14d
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kaiwenw
force-pushed
the
separate_unittest
branch
6 times, most recently
from
9f41166 to
f8314b1
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@kaiwenw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 9, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: e321592de1ad40bdc7891f32eefef0659fff2b4b
|
This pull request was exported from Phabricator. Differential Revision: D21489212 |
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 10, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 326ad47213383bd975bc49e9b82d1d61738d8416
kaiwenw
force-pushed
the
separate_unittest
branch
from
2118f7d to
0bf48b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21489212 |
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 84.04% 85.12% +1.07%
==========================================
Files 225 226 +1
Lines 14473 14487 +14
Branches 42 42
==========================================
+ Hits 12164 12332 +168
+ Misses 2285 2131 -154
Partials 24 24
Continue to review full report at Codecov.
|
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 4872e898700c4b3afcd0bb064b95d4394465b3ae
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: b2219ed5a18e6abfe87966561e368527649c5d21
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: eee22283cf9b18cbb4db761cc4f1be1301546337
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: c9b3a4f1e18129b81e79c1c0940fe9ae901ed625
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 82bcf6fb010e2c05291241b47abc42a95adaa654
kaiwenw
force-pushed
the
separate_unittest
branch
from
0bf48b0 to
a0b8966
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21489212 |
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 9fd69acd039c870ee5cf57229369eb67cc430bde
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: de8c8e56d616d88806f1f3c2a382cbe0a8218a68
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: f5cd01154ed443f8ff8d935fee401417fb03e85e
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Reviewed By: kittipatv Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: a550d66b9a62e997e1e33fbc2ad3b3540e0b5044
kaiwenw
force-pushed
the
separate_unittest
branch
from
a0b8966 to
6b72b93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21489212 |
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: da484a1abb902bf2fd1017f914878653415f7f22
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 43dda06e8934a13fb98ff7196fbb4f28e4e52ca3
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 11, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 0746d4fb97b2872f6e851bde5218eddfd594e32e
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Reviewed By: kittipatv Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 783546980a77e267930d5f153a8973481367f960
kaiwenw
force-pushed
the
separate_unittest
branch
from
6b72b93 to
74a24dd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21489212 |
kaiwenw
added a commit
to kaiwenw/ReAgent
that referenced
this pull request
May 12, 2020
…rch#261) Summary: - Add coverage.py for end-to-end test. - Make setup.cfg only contain what the user needs to run, and move testing specific options to tox and circleci config. - Split gpu_unittest into gym tests and everything else - Improve test stability. Pull Request resolved: facebookresearch#261 Differential Revision: D21489212 Pulled By: kaiwenw fbshipit-source-id: 8ad82e139e65d1de04f9a5cd2032f81f83646ccf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.