Skip to content

Fix TimelineTest in OSS #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kittipatv wants to merge 1 commit into from
Closed

Fix TimelineTest in OSS #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion preprocessing/src/test/scala/com/facebook/spark/rl/TimelineTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,9 @@ class TimelineTest extends PipelineTester {
import sqlCtx.implicits._
val sparkContext = sqlCtx.sparkContext

val percentileFunc =
if (sparkContext.version >= "2.3.0") "approx_percentile" else "fb_approx_percentile"

// Setup configuration
val config = TimelineConfiguration("2018-01-01",
"2018-01-01",
Expand All @@ -559,7 +562,7 @@ class TimelineTest extends PipelineTester {
null,
1,
Some(0.95),
"fb_approx_percentile")
percentileFunc)

// destroy previous schema
Timeline.validateOrDestroyTrainingTable(sqlContext,
Expand Down