fully revert tensor changes in dim_grid#460
Closed
JasonKChow wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66374663 |
Summary: dim_grid tensor changes were only half reverted for some reason. This fully reverts it and fixes a bug where dim_grid was producing double the number of points when slicing. Differential Revision: D66374663
JasonKChow
force-pushed
the
export-D66374663
branch
from
e860ec3 to
fde7d66
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66374663 |
Contributor
|
This pull request has been merged in aa36126. |
JasonKChow
added a commit
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: #460 dim_grid tensor changes were only half reverted for some reason. This fully reverts it and fixes a bug where dim_grid was producing double the number of points when slicing. Reviewed By: crasanders Differential Revision: D66374663 fbshipit-source-id: c2226b59c6320bedf74c3374f6ae1347f47e4e26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: dim_grid tensor changes were only half reverted for some reason. This fully reverts it and fixes a bug where dim_grid was producing double the number of points when slicing.
Differential Revision: D66374663