Make cleaning up temporary databases more reliable#770
Closed
JasonKChow wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72811319 |
JasonKChow
force-pushed
the
export-D72811319
branch
from
2210d68 to
82b6e12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72811319 |
JasonKChow
force-pushed
the
export-D72811319
branch
from
82b6e12 to
d51a5a0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72811319 |
Summary: Making warnings cause errors to make CI more reliable in finding problems. Differential Revision: D72811244
JasonKChow
force-pushed
the
export-D72811319
branch
from
d51a5a0 to
3f49d25
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72811319 |
Contributor
|
This pull request has been merged in b0e804d. |
JasonKChow
added a commit
that referenced
this pull request
Apr 11, 2025
Summary: Pull Request resolved: #770 Temporary databases now more cleanly delete themselves even if connection has already been cleaned up. Reviewed By: adellari Differential Revision: D72811319 fbshipit-source-id: 0a81098387e67f64ff704eb15ef35a7d27957cbc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Temporary databases now more cleanly delete themselves even if connection has already been cleaned up.
Differential Revision: D72811319