Change 2D Detection Sample Experiment start#821
Closed
JasonKChow wants to merge 5 commits intofacebookresearch:mainfrom
Closed
Change 2D Detection Sample Experiment start#821JasonKChow wants to merge 5 commits intofacebookresearch:mainfrom
JasonKChow wants to merge 5 commits intofacebookresearch:mainfrom
Conversation
Summary: Samples were using the old Ask api. Update all of them to use the new one so the samples can actually run. Pairwise experiments probably don’t work still, but this is a start. Differential Revision: D81801883
Summary: Config generator would put the acqf in strategy which we do not support anymore. Moved it to the generator. Differential Revision: D81801882
Summary: Get_strat used to expect just an integer but all messages are now dictionaries. We can actually parse it now. Differential Revision: D81809363
Summary: can_model message no longer exists and got rolled into the info message. Updated the client to reflect that. Differential Revision: D81825159
Summary: The sample for a 2D detection experiment needs to specifically be manual, we force this change in the metadata. Differential Revision: D81833064
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81833064 |
tymmsc
approved these changes
Sep 8, 2025
Contributor
tymmsc
left a comment
tymmsc
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in 9a3a6cb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The sample for a 2D detection experiment needs to specifically be manual, we force this change in the metadata.
Differential Revision: D81833064