Remove mypy from actions#829
Closed
JasonKChow wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@JasonKChow has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91599368. |
tymmsc
approved these changes
Jan 27, 2026
Contributor
tymmsc
left a comment
tymmsc
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: We can’t keep supporting mypy given some larger API changes that don’t actually break our code but messed with type checking. We need larger refactors to make this work but we can’t support it right now. So temporarily disabling mypy with note. Reviewed By: tymmsc Differential Revision: D91599368
JasonKChow
force-pushed
the
export-D91599368
branch
from
1387171 to
606ba13
Compare
|
This pull request has been merged in 5977250. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We can’t keep supporting mypy given some larger API changes that don’t actually break our code but messed with type checking. We need larger refactors to make this work but we can’t support it right now. So temporarily disabling mypy with note.
Differential Revision: D91599368