Replace deprecated categorical dtype detection#197
Closed
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Replace deprecated categorical dtype detection#197neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
neuralsorcerer wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a deprecation warning by replacing the deprecated pd_types.is_categorical_dtype() function with the recommended isinstance(dtype, pd.CategoricalDtype) check.
Key Changes:
- Updated
_is_categorical_dtype()function inbalance/util.pyto useisinstance(dtype, pd.CategoricalDtype)instead of the deprecatedpd_types.is_categorical_dtype(dtype)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D88366966. |
|
@talgalili merged this pull request in d6775d6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced deprecated categorical dtype detection to eliminate pandas warnings during tests.