Fix PYRE_FIXME issue in fbcode/core_stats/balance/sample_class.py#299
Closed
talgalili wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Fix PYRE_FIXME issue in fbcode/core_stats/balance/sample_class.py#299talgalili wants to merge 1 commit intofacebookresearch:mainfrom
talgalili wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Differential Revision: D91468929
|
@talgalili has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91468929. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Pyre type checking issue by adding an explicit type annotation to the _adjustment_model class attribute in the Sample class, replacing a PYRE_FIXME suppression comment.
Changes:
- Replaced
# pyre-fixme[4]: Attributes are initialized in from_frame()comment with explicit type annotation_adjustment_model: Dict[str, Any] | None = None
|
This pull request has been merged in 6ed9935. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D91468929