This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Make lightning reproducible #661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
In this diff we make changes to ensure we can control reproducibility in d2go:
- update setup.py to enforce deterministic performance if set via config
- set lightning parameters if deterministic is passed:
```
{
"sync_batchnorm": True,
"deterministic": True,
"replace_sampler_ddp": False,
}
```
- allow passing prefetch_factor, pin_memory, persistent_memory as args to batch dataloader.
- minor fix in training sampler
Differential Revision: D55767128
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55767128 |
facebook-github-bot
pushed a commit
to facebookresearch/detectron2
that referenced
this pull request
May 2, 2024
Summary: X-link: facebookresearch/d2go#661 X-link: fairinternal/detectron2#603 Pull Request resolved: #5273 In this diff we make changes to ensure we can control reproducibility in d2go: - update setup.py to enforce deterministic performance if set via config - set lightning parameters if deterministic is passed: ``` { "sync_batchnorm": True, "deterministic": True, "replace_sampler_ddp": False, } ``` - allow passing prefetch_factor, pin_memory, persistent_memory as args to batch dataloader. - minor fix in training sampler Differential Revision: D55767128 fbshipit-source-id: eeab50c95969a91c58f1773473b6fc666494cc16
Contributor
|
This pull request has been merged in aa7716b. |
jackhhao
pushed a commit
to mimic-labs/detectron2
that referenced
this pull request
May 7, 2024
Summary: X-link: facebookresearch/d2go#661 X-link: https://github.com/fairinternal/detectron2/pull/603 Pull Request resolved: facebookresearch#5273 In this diff we make changes to ensure we can control reproducibility in d2go: - update setup.py to enforce deterministic performance if set via config - set lightning parameters if deterministic is passed: ``` { "sync_batchnorm": True, "deterministic": True, "replace_sampler_ddp": False, } ``` - allow passing prefetch_factor, pin_memory, persistent_memory as args to batch dataloader. - minor fix in training sampler Differential Revision: D55767128 fbshipit-source-id: eeab50c95969a91c58f1773473b6fc666494cc16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff we make changes to ensure we can control reproducibility in d2go:
Differential Revision: D55767128