This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Hipify various dependencies to enable AMD Face Enhancer #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff extends several targets to be hip compatible and fixes a few silly hipification issues with those targets. After these changes, all dependencies needed for the face enhancer can compile with AMD. A few silly issues that I had to hack around, maybe we could improve hipification to avoid similar issues in the future: * Some of the dependencies used sources in `src/cuda/**.cu`. Hipification tried to rename "cuda" to "hip" and broke the paths. I'm not sure where that rename happens so I just changed the directory from "cuda" to "gpu" to avoid the issue. * One header import called `THCAtomics.cuh` was incorrectly being renamed to `THHAtomics.cuh`, which doesnt exist. Fortunately an equivalent import that doesnt have name issues was available. We also might want to consider graduating the cpp_library_hip bazel helper out of fbgemm since it seems pretty generally useful. For some of the targets, we needed to build a python cpp extension, which as far as I can tell we didnt have good hipification for yet. I added a new buck rule very similar to our standard cpp_library_hip rule that creates an extension instead. It's a little copy-pasted so if there are cleaner ways to work around this requirement let me know. Reviewed By: jianyuh Differential Revision: D61080247
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61080247 |
Contributor
|
This pull request has been merged in 7739077. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff does some minor cleanup to enable d2go to compile for both Cuda and AMD. Specifically, we have automated hipification scripts that make cuda code compatible for AMD compilation. However, it was struggling with some of the names and imports in this repo. Changing the name "cuda" to "gpu" helped resolve some of those issues and making the header imports a little cleaner fixed the rest.
Reviewed By: jianyuh
Differential Revision: D61080247