Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@wat3rBro
Copy link
Contributor

Summary:
Refactor the base test case

  • make test_dir valid throughout the test (rather than under local context), so individual test can load back the export model
  • refactor the custom_setup_test for easier override.
  • move parameterized into base class to avoid copying naming function

Differential Revision: D28651067

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels May 24, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28651067

Summary:
Pull Request resolved: facebookresearch#75

Refactor the base test case
- make test_dir valid throughout the test (rather than under local context), so individual test can load back the export model
- refactor the `custom_setup_test` for easier override.
- move parameterized into base class to avoid copying naming function

Differential Revision: D28651067

fbshipit-source-id: a05a581373717754e15ac85ea6e8a02645893259
@wat3rBro wat3rBro force-pushed the export-D28651067 branch from 1489f69 to 242e887 Compare May 24, 2021 20:49
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28651067

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0ab6d3f.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants