[refactor] OSS - broadcasts - getting rid of the while loop#165
Merged
blefaudeux merged 3 commits intomasterfrom Oct 23, 2020
Merged
[refactor] OSS - broadcasts - getting rid of the while loop#165blefaudeux merged 3 commits intomasterfrom
blefaudeux merged 3 commits intomasterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
min-xu-ai
reviewed
Oct 23, 2020
min-xu-ai
approved these changes
Oct 23, 2020
Contributor
min-xu-ai
left a comment
min-xu-ai
left a comment
There was a problem hiding this comment.
LGTM! nice refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
No logic changes, still doing the exact same thing as before, bucket the first small params, broadcast asynchronously, then directly broadcast the rest and get back to the bucket
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃