Add default noising argument in WordNoiser initialization #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…search#664) Summary: Pull Request resolved: facebookresearch#664 Previously arguments for noising (dropout_prob for WordDropout and max_shuffle_distance for WordShuffle) are only passed in noising() so it could not be customized in NoisingDataset. Now add default argument in initializer so the value could be specified at construction. Reviewed By: liezl200 Differential Revision: D15071632 fbshipit-source-id: 7604a974221ec963b90f6b4a144b348e980bc3bb
Contributor
|
This pull request has been merged in 3742085. |
Harleen8118
pushed a commit
to Harleen8118/IBERT
that referenced
this pull request
Jun 26, 2025
Summary: Pull Request resolved: facebookresearch/fairseq#664 Previously arguments for noising (dropout_prob for WordDropout and max_shuffle_distance for WordShuffle) are only passed in noising() so it could not be customized in NoisingDataset. Now add default argument in initializer so the value could be specified at construction. Reviewed By: liezl200 Differential Revision: D15071632 fbshipit-source-id: 59a9bf5a5e6d03c1e74f1b31c1927e221cb11dfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously arguments for noising (dropout_prob for WordDropout and max_shuffle_distance for WordShuffle) are only passed in noising() so it could not be customized in NoisingDataset.
Now add default argument in initializer so the value could be specified at construction.
Differential Revision: D15071632