Fix IP metric distance computation in multi-bit RaBitQ#4751
Closed
alibeklfc wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Fix IP metric distance computation in multi-bit RaBitQ#4751alibeklfc wants to merge 1 commit intofacebookresearch:mainfrom
alibeklfc wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Summary: The correction term in compute_ex_factors() for INNER_PRODUCT metric was causing test failures. Removing it and using the simplified formula `f_add_ex = 1 - ip_resi_cent` fixes the IP metric recall tests. Differential Revision: D90430458
Contributor
|
@alibeklfc has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90430458. |
Contributor
|
This pull request has been merged in 5e7942d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The correction term in compute_ex_factors() for INNER_PRODUCT metric was causing test failures. Removing it and using the simplified formula
f_add_ex = 1 - ip_resi_centfixes the IP metric recall tests.Differential Revision: D90430458