Sync CMake tests with BUCK and remove flaky test#4782
Closed
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Sync CMake tests with BUCK and remove flaky test#4782algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
algoriddle wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Contributor
|
@algoriddle has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91814033. |
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 29, 2026
Summary: - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Differential Revision: D91814033
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 29, 2026
Summary: - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Differential Revision: D91814033
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookresearch#4782 - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
force-pushed
the
export-D91814033
branch
from
a0c6a6c to
c1a42ab
Compare
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookresearch#4782 - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
force-pushed
the
export-D91814033
branch
2 times, most recently
from
35bbaf4 to
bef38a8
Compare
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookresearch#4782 - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookresearch#4782 - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
force-pushed
the
export-D91814033
branch
from
bef38a8 to
a89818e
Compare
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookresearch#4782 - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
force-pushed
the
export-D91814033
branch
from
a89818e to
874dfc7
Compare
algoriddle
added a commit
to algoriddle/faiss
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookresearch#4782 - Remove test_mem_leak.cpp (always skipped, removed from BUCK in D73790172) - Add missing tests to CMakeLists.txt that exist in BUCK: - test_NSG_compressed_graph - test_pqfs_unaligned - test_scalar_quantizer - test_factory_tools Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
force-pushed
the
export-D91814033
branch
from
874dfc7 to
cca3737
Compare
…bookresearch#4782) Summary: Pull Request resolved: facebookresearch#4782 This diff makes several cleanups to prepare for Dynamic Dispatch: Move factory_tools from cppcontrib to main faiss library: - Moves factory_tools.cpp/h from faiss/cppcontrib/ to faiss/ - Removes the separate //faiss/cppcontrib:factory_tools target - Updates all includes to use <faiss/factory_tools.h> - Updates xplat.bzl to include factory_tools in source/header lists Fix unaligned SIMD store in simd_result_handlers.h: - Changes store() to storeu() for potentially unaligned memory - Fixes crashes in test_pqfs_unaligned when compiled with SIMD flags Sync CMake tests with BUCK: - Add missing tests: test_NSG_compressed_graph, test_pqfs_unaligned, test_scalar_quantizer - Remove test_mem_leak.cpp (already removed from BUCK in D73790172) - Move test_factory_tools from cppcontrib tests to main tests Add autodeps-skip to faiss library targets: - Prevents autodeps from modifying carefully configured SIMD build settings Reviewed By: junjieqi Differential Revision: D91814033
algoriddle
force-pushed
the
export-D91814033
branch
from
cca3737 to
9708603
Compare
Contributor
|
This pull request has been merged in 31b47ba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D91814033