Closed
Conversation
aknayar
commented
Jan 31, 2026
| @@ -0,0 +1,695 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
Contributor
Author
There was a problem hiding this comment.
Just renamed test_flat_l2_panorama and added iteration over metric types.
aknayar
commented
Feb 1, 2026
| } | ||
|
|
||
| // IndexFlatIPPanorama | ||
| if (match("FlatIPPanorama([0-9]+)(_[0-9]+)?")) { |
Contributor
Author
There was a problem hiding this comment.
Ideally I would replace this and FlatL2Panorama with just FlatPanorama (similar to how is done for IndexFlat), but I think that would break backward compatibility for those using index_factory("FlatL2Panorama...").
Contributor
|
@alibeklfc has imported this pull request. If you are a Meta employee, you can view this in D92071847. |
Contributor
|
@alibeklfc merged this pull request in cddb5c3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #4732, adding
IndexFlatIPPanoramaand updating unit tests.Hide whitespace to see cleaner diffs.
Note: Renamed
test_flat_l2_panorama.py->test_flat_panorama.py.