Closed
Conversation
Contributor
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Feb 12, 2026
Summary: Dynamic dispatching will be performed when fvec_L2sqr is called. This is problematic for tight loops. This diff moves the dispatching one level above in the calling code to avoid this pitfall. In particular, the VectorDistance dispatcher now takes not only the metric type into account but also the SIMD level. The consequence is that there should be no degradation for IVFFlat. Reviewed By: algoriddle Differential Revision: D92966745
mdouze
force-pushed
the
export-D92966745
branch
from
3e3146e to
253c79c
Compare
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Feb 12, 2026
Summary: Dynamic dispatching will be performed when fvec_L2sqr is called. This is problematic for tight loops. This diff moves the dispatching one level above in the calling code to avoid this pitfall. In particular, the VectorDistance dispatcher now takes not only the metric type into account but also the SIMD level. The consequence is that there should be no degradation for IVFFlat. Reviewed By: algoriddle Differential Revision: D92966745
mdouze
force-pushed
the
export-D92966745
branch
from
253c79c to
fab8aa7
Compare
Summary: Dynamic dispatching will be performed when fvec_L2sqr is called. This is problematic for tight loops. This diff moves the dispatching one level above in the calling code to avoid this pitfall. In particular, the VectorDistance dispatcher now takes not only the metric type into account but also the SIMD level. The consequence is that there should be no degradation for IVFFlat. Reviewed By: algoriddle Differential Revision: D92966745
mdouze
force-pushed
the
export-D92966745
branch
from
fab8aa7 to
dc63dfb
Compare
Contributor
|
This pull request has been merged in 55698d7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Dynamic dispatching will be performed when fvec_L2sqr is called. This is problematic for tight loops.
This diff moves the dispatching one level above in the calling code to avoid this pitfall.
In particular, the VectorDistance dispatcher now takes not only the metric type into account but also the SIMD level. The consequence is that there should be no degradation for IVFFlat.
Reviewed By: algoriddle
Differential Revision: D92966745