Harden ZnSphere lattice codec against invalid parameters#4826
Closed
sh00s wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Harden ZnSphere lattice codec against invalid parameters#4826sh00s wants to merge 2 commits intofacebookresearch:mainfrom
sh00s wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
added 2 commits
February 20, 2026 13:45
Summary: Add n_levels > 0 check in Panorama::set_derived_values() to prevent division by zero, and validate n_levels during deserialization. Reviewed By: mdouze Differential Revision: D93670703
Summary: Add bounds checks for dim and r2 in ZnSphereSearch and ZnSphereCodecRec constructors to prevent excessive computation and allocation overflows from corrupted deserialized data. Reviewed By: mdouze Differential Revision: D93670702
Contributor
Contributor
|
This pull request has been merged in 0bbf770. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add bounds checks for dim and r2 in ZnSphereSearch and ZnSphereCodecRec constructors to prevent excessive computation and allocation overflows from corrupted deserialized data.
Reviewed By: mdouze
Differential Revision: D93670702