Replace dispatch_HammingComputer with with_HammingComputer#5126
Closed
mdouze wants to merge 1 commit into
Closed
Conversation
Summary:
Replace the dispatch_HammingComputer + Run_XXX consumer struct pattern with
with_HammingComputer that takes a C++20 template lambda directly. This
eliminates boilerplate wrapper structs across 8 files.
Before:
struct Run_foo { using T = void; template<class HC, class... T> void f(T... a) { foo<HC>(a...); } };
Run_foo r; dispatch_HammingComputer(code_size, r, args...);
After:
with_HammingComputer(code_size, [&]<class HC>() { foo<HC>(args...); });
Reviewed By: algoriddle
Differential Revision: D101350351
Contributor
|
@mdouze has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101350351. |
Contributor
|
This pull request has been merged in e23c661. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the dispatch_HammingComputer + Run_XXX consumer struct pattern with
with_HammingComputer that takes a C++20 template lambda directly. This
eliminates boilerplate wrapper structs across 8 files.
Before:
struct Run_foo { using T = void; template<class HC, class... T> void f(T... a) { foo(a...); } };
Run_foo r; dispatch_HammingComputer(code_size, r, args...);
After:
with_HammingComputer(code_size, [&]() { foo(args...); });
Reviewed By: algoriddle
Differential Revision: D101350351