Skip to content

Remove stale preconditioner config names from __init__.py #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runame wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove stale preconditioner config names from __init__.py #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions distributed_shampoo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
from distributed_shampoo.shampoo_types import (
AdaGradPreconditionerConfig,
AdamPreconditionerConfig,
AmortizedPreconditionerConfig,
BaseShampooPreconditionerConfig,
ClassicShampooPreconditionerConfig,
DDPDistributedConfig,
DefaultEigenvalueCorrectedShampooConfig,
DefaultShampooConfig,
Expand All @@ -59,7 +60,6 @@
RootInvShampooPreconditionerConfig,
ScheduleFreeConfig,
SGDPreconditionerConfig,
ShampooPreconditionerConfig,
ShampooPT2CompileConfig,
SignDescentPreconditionerConfig,
SingleDeviceDistributedConfig,
Expand All @@ -85,14 +85,14 @@
# `precision_config`.
# `preconditioner_config` options.
"PreconditionerConfig", # Abstract base class.
"AmortizedPreconditionerConfig", # Abstract base class (based on `PreconditionerConfig`).
"ShampooPreconditionerConfig", # Abstract base class (based on `AmortizedPreconditionerConfig`).
"RootInvShampooPreconditionerConfig", # Based on `ShampooPreconditionerConfig`.
"BaseShampooPreconditionerConfig", # Abstract base class (based on `PreconditionerConfig`).
"ClassicShampooPreconditionerConfig", # Abstract base class (based on `BaseShampooPreconditionerConfig`).
"RootInvShampooPreconditionerConfig", # Based on `ClassicShampooPreconditionerConfig`.
"DefaultShampooConfig", # Default `RootInvShampooPreconditionerConfig` using `EigenConfig`.
"RootInvKLShampooPreconditionerConfig", # Based on `RootInvShampooPreconditionerConfig`.
"EigendecomposedShampooPreconditionerConfig", # Based on `ShampooPreconditionerConfig`.
"EigendecomposedShampooPreconditionerConfig", # Based on `ClassicShampooPreconditionerConfig`.
"EigendecomposedKLShampooPreconditionerConfig", # Based on `EigendecomposedShampooPreconditionerConfig`.
"EigenvalueCorrectedShampooPreconditionerConfig", # Based on `AmortizedPreconditionerConfig`.
"EigenvalueCorrectedShampooPreconditionerConfig", # Based on `BaseShampooPreconditionerConfig`.
"DefaultEigenvalueCorrectedShampooConfig", # Default `EigenvalueCorrectedShampooPreconditionerConfig` using `EighEigendecompositionConfig`.
"DefaultSOAPConfig", # Default `EigenvalueCorrectedShampooPreconditionerConfig` using `QREigendecompositionConfig`.
"SpectralDescentPreconditionerConfig", # Based on `PreconditionerConfig`.
Expand Down
Loading