Add p90 and p99 percentile tracking to pipeline performance stats#1306
Merged
Add p90 and p99 percentile tracking to pipeline performance stats#1306
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@moto-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97726875. |
) Summary: Add p90 and p99 percentile tracking to SPDL pipeline performance statistics. Implements the P-square algorithm for streaming percentile estimation with O(1) memory and O(1) per-update complexity. Updates `TaskPerfStats` and `QueuePerfStats` dataclasses to include p90/p99 fields, modifies collection logic in hooks and queues to track percentiles, and updates logging to report the new metrics. Also updates the SQLite stats logger example to accommodate the schema changes. --- AI generated Summary & Test Plan from DEV122498560 Differential Revision: D97726875
meta-codesync
bot
changed the title
meta-codesync
bot
force-pushed
the
export-D97726875
branch
from
4f908e2 to
22fd463
Compare
mthrok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add p90 and p99 percentile tracking to SPDL pipeline performance statistics. Implements the P-square algorithm for streaming percentile estimation with O(1) memory and O(1) per-update complexity. Updates
TaskPerfStatsandQueuePerfStatsdataclasses to include p90/p99 fields, modifies collection logic in hooks and queues to track percentiles, and updates logging to report the new metrics. Also updates the SQLite stats logger example to accommodate the schema changes.AI generated Summary & Test Plan from DEV122498560
Differential Revision: D97726875