Skip to content

Conversation

@igogrek
Copy link

@igogrek igogrek commented Jun 14, 2017

Thanks for the plugin - it works great (we were finally able to fix this issue with extract-text-plugin).
But in our project we don't need the .no_css.js chunks and I've added an option to skip creation of them.

@faceyspacey
Copy link
Owner

Thanks for this. It's a solid idea. I'll merge it. Just give me a day or 2 to marinate on the option name before committing to it.

@igogrek
Copy link
Author

igogrek commented Jun 14, 2017

You're probably right. Will noCssChunks with default value of true be better instead?

@faceyspacey
Copy link
Owner

yea that's the sorta stuff in my head. ...now we just gotta figure out if we can come up with a word that only has 2 camel humps or even one.

BowlingX added a commit to BowlingX/extract-css-chunks-webpack-plugin that referenced this pull request Jun 16, 2017
@faceyspacey faceyspacey mentioned this pull request Jun 17, 2017
@igogrek
Copy link
Author

igogrek commented Jul 4, 2017

So, any thoughts on how the option should be named after all?

@faceyspacey
Copy link
Owner

2.0 is out!

check this:
https://medium.com/faceyspacey/webpacks-import-will-soon-fetch-js-css-here-s-how-you-do-it-today-4eb5b4929852

and this
https://github.com/faceyspacey/babel-plugin-dual-import

and the readme to this package is updated.

The short story is the problem is solved in a different way now, which involves only no_css chunks + css. The babel plugin will import both a js + css file! Let me know what you think.

@faceyspacey faceyspacey closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants