feat(hotLoading): Addressing some issues in HMR #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ScriptedAlchemy
commented
Dec 23, 2018
ScriptedAlchemy
commented
- CSS modules should have better HMR.
- Updates and renames were also done that appear to have gotton lost
- Fixed up CSS reloadAll
- Dont assume CSS modules be default
- Also fixing css loading order issues that appear during HMR
- Pulling in a handful of fixes from webpack
- fixed broken tests
- New linting rules
- Editor configs
- prettier config added
- commitlint configs added
- some dependency updates
CSS modules should have better HMR. Updates and renames were also done that appear to have gotton lost Fixed up CSS reloadAll Dont assume CSS modules be default Also fixing css loading order issues that appear during HMR Pulling in a handful of fixes from webpack
Following webpack here and getting my tests passing again
New linting rules Editor configs prettier config added commitlint configs added some dependency updates
ScriptedAlchemy
force-pushed
the
minor-overhaul
branch
from
4722e5a to
16830d4
Compare
Collaborator
Author
|
Release failed due to force push, so ill neeed to run it manually |
Owner
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.