feat(restore): logical file rename#102
Merged
Miguel Arana (mja9) merged 8 commits intomasterfrom May 4, 2022
Merged
Conversation
Miguel Arana (mja9)
requested review from
Aditya Niraula (AdityaNPL) and
Alex Irion (alexirion10)
Contributor
Aditya Niraula (AdityaNPL)
left a comment
Aditya Niraula (AdityaNPL)
left a comment
There was a problem hiding this comment.
Couple of questions/suggestions below
Alex Irion (alexirion10)
suggested changes
May 2, 2022
Miguel Arana (mja9)
requested review from
Aditya Niraula (AdityaNPL) and
Alex Irion (alexirion10)
Aditya Niraula (AdityaNPL)
approved these changes
May 3, 2022
Contributor
Aditya Niraula (AdityaNPL)
left a comment
Aditya Niraula (AdityaNPL)
left a comment
There was a problem hiding this comment.
LGTM!
Just a quick Q below
Alex Irion (alexirion10)
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes to
Restoreto rename logical files usingfileRelocatorwhen passed in.Tested in separate console application, verified logical names had changed in SSMS