fix(backup-chain): next log backup can have the same LastLsn#103
Merged
Aditya Niraula (AdityaNPL) merged 5 commits intomasterfrom May 9, 2022
Merged
fix(backup-chain): next log backup can have the same LastLsn#103Aditya Niraula (AdityaNPL) merged 5 commits intomasterfrom
LastLsn#103Aditya Niraula (AdityaNPL) merged 5 commits intomasterfrom
Conversation
Aditya Niraula (AdityaNPL)
requested review from
Alex Irion (alexirion10),
Miguel Arana (mja9) and
slin5299
Contributor
Alex Irion (alexirion10)
left a comment
Alex Irion (alexirion10)
left a comment
There was a problem hiding this comment.
Not sure what scenario caused this, but ok. Take a look at the failing unit test plz
Contributor
Author
|
Unit test:
huh, that's weird - checking |
Contributor
Author
|
uggh, infinite loop while building the chain cause it's matching the same log backup over and over again |
Contributor
Author
|
Fixed the infinite loop by making sure it isn't getting the same backup as the last one Tested on a MSSQL DB with the lastLSNs equal for two of the backups |
Alex Irion (alexirion10)
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(It looks like it made loads of white space changes automatically - pls ignore this while reviewing.)
I came across an instance where the
LastLsnwas the same for 2 backups. Hence, this check was filtering the log backup out.