Unpin jsonschema#31
Closed
Mike Stipicevic (mst-ableton) wants to merge 1 commit intofactset:masterfrom
mst-ableton:update_jsonschema
Closed
Unpin jsonschema#31Mike Stipicevic (mst-ableton) wants to merge 1 commit intofactset:masterfrom mst-ableton:update_jsonschema
Mike Stipicevic (mst-ableton) wants to merge 1 commit intofactset:masterfrom
mst-ableton:update_jsonschema
Conversation
Contributor
Author
|
Hmm, the tests worked locally. I'm not sure what's going on here... |
Contributor
|
I'll take a look |
Contributor
|
Closing in favor of #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10,
jsonschemawas pinned in order to prevent the roll to 3.x.x which was still in alpha. It's been out of alpha for a while now, so this PR unpins the dependency. I'm not sure about any breaking changes, as the tests still seem to pass. Feel free to adopt/rewrite this PR if there are things I've missed, thanks!