Skip to content

finishing the porting of node_is_type rule condition issue-2281117#53

Closed
andrewgwardwell wants to merge 1 commit intofago:8.x-3.xfrom
andrewgwardwell:node_is_of_type_condition-2281117
Closed

finishing the porting of node_is_type rule condition issue-2281117#53
andrewgwardwell wants to merge 1 commit intofago:8.x-3.xfrom
andrewgwardwell:node_is_of_type_condition-2281117

Conversation

@andrewgwardwell
Copy link
Copy Markdown

Rules condition for testing if a node is of a certain type.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break between opening php tag and file comment.

@fubhy
Copy link
Copy Markdown
Collaborator

fubhy commented Jun 6, 2014

Code looking good, thanks! Before I merge this, can you please do this:

  1. git rebase -i HEAD~2
  2. pick the first, squash the second
  3. provide a single, good and concise commit message
  4. git push origin --force (given that your remote is named 'origin')

This will help us to keep the git log clean by ensuring that we always merge full feature implementations and not commits like "fixing this..", "adding newline" etc.

It is called "squashing". There is a nice explaining of it in the symfony contribution docs: http://symfony.com/doc/current/cmf/contributing/commits.html

Thanks!

@fubhy
Copy link
Copy Markdown
Collaborator

fubhy commented Jun 9, 2014

Merged, thanks!

I converted the simple test implementation to a unit test upon merge.

@fubhy fubhy closed this Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants