finishing the porting of node_is_type rule condition issue-2281117#53
Closed
andrewgwardwell wants to merge 1 commit intofago:8.x-3.xfrom
Closed
finishing the porting of node_is_type rule condition issue-2281117#53andrewgwardwell wants to merge 1 commit intofago:8.x-3.xfrom
andrewgwardwell wants to merge 1 commit intofago:8.x-3.xfrom
Conversation
Collaborator
There was a problem hiding this comment.
Missing line break between opening php tag and file comment.
Collaborator
|
Code looking good, thanks! Before I merge this, can you please do this:
This will help us to keep the git log clean by ensuring that we always merge full feature implementations and not commits like "fixing this..", "adding newline" etc. It is called "squashing". There is a nice explaining of it in the symfony contribution docs: http://symfony.com/doc/current/cmf/contributing/commits.html Thanks! |
Collaborator
|
Merged, thanks! I converted the simple test implementation to a unit test upon merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules condition for testing if a node is of a certain type.