fix: 🐛 Fix potential warning in factory.py #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ellipsis replace pass to avoid potential warning: ``` "resource": "/d:/Github/Python/python-patterns/patterns/creational/factory.py", "owner": "pylance4", "value": "reportReturnType", "path": "/microsoft/pylance-release/blob/main/docs/diagnostics/reportReturnType.md", "severity": 8, "message": "Function with declared return type \"str\" must return value on all code paths\n \"None\" is not assignable to \"str\"", "source": "Pylance", "startLineNumber": 29, "startColumn": 37, "endLineNumber": 29, "endColumn": 40, "origin": "extHost1" }] ``` Using VS Code with Pylance, Python debugger, and Black Formatter.
grimley517
reviewed
Oct 15, 2025
| class Localizer(Protocol): | ||
| def localize(self, msg: str) -> str: | ||
| pass | ||
| def localize(self, msg: str) -> str: ... |
There was a problem hiding this comment.
Good idea - definitely more in line with modern usage. However; shouldn't the ellipsis go on the next line?
There was a problem hiding this comment.
Yes, but I equipped black formatter as requested.
Black formatter insists that ellipsis go the exact same line with the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ellipsis replace pass to avoid potential warning:
Using VS Code with Pylance, Python debugger, and Black Formatter.