-
Notifications
You must be signed in to change notification settings - Fork 4
bumped versions and fixed command-line interface #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b4d8fa to
b753839
Compare
424f72e to
6740e63
Compare
6740e63 to
edeefe1
Compare
3068bde to
7d03883
Compare
7d03883 to
1ba9d10
Compare
| <version>${version.jetty}</version> | ||
| </dependency> | ||
| <!-- bump jetty version due to CVE issue --> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severe OSS Vulnerability:
pkg:maven/org.eclipse.jetty/jetty-http@9.4.40.v20210413
0 Critical, 1 Severe, 0 Moderate and 0 Unknown vulnerabilities have been found in a transitive dependency of pkg:maven/org.eclipse.jetty/jetty-server@9.4.40.v20210413
SEVERE Vulnerabilities (1)
[CVE-2021-28169] For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for r...
For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for requests to the ConcatServlet with a doubly encoded path to access protected resources within the WEB-INF directory. For example a request to
/concat?/%2557EB-INF/web.xmlcan retrieve the web.xml file. This can reveal sensitive information regarding the implementation of a web application.CVSS Score: 5.3
CVSS Vector: CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N
(at-me in a reply with help or ignore)
| <artifactId>jetty-server</artifactId> | ||
| <version>${version.jetty}</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severe OSS Vulnerability:
pkg:maven/org.eclipse.jetty/jetty-http@9.4.40.v20210413
0 Critical, 1 Severe, 0 Moderate and 0 Unknown vulnerabilities have been found in a transitive dependency of pkg:maven/org.eclipse.jetty/jetty-webapp@9.4.40.v20210413
SEVERE Vulnerabilities (1)
[CVE-2021-28169] For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for r...
For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for requests to the ConcatServlet with a doubly encoded path to access protected resources within the WEB-INF directory. For example a request to
/concat?/%2557EB-INF/web.xmlcan retrieve the web.xml file. This can reveal sensitive information regarding the implementation of a web application.CVSS Score: 5.3
CVSS Vector: CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N
(at-me in a reply with help or ignore)
| <version>${version.jetty}</version> | ||
| </dependency> | ||
| <!-- bump jetty version due to CVE issue --> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severe OSS Vulnerability:
pkg:maven/org.eclipse.jetty/jetty-server@9.4.40.v20210413
0 Critical, 1 Severe, 0 Moderate and 0 Unknown vulnerabilities have been found in a direct dependency
SEVERE Vulnerabilities (1)
[CVE-2021-28169] For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for r...
For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for requests to the ConcatServlet with a doubly encoded path to access protected resources within the WEB-INF directory. For example a request to
/concat?/%2557EB-INF/web.xmlcan retrieve the web.xml file. This can reveal sensitive information regarding the implementation of a web application.CVSS Score: 5.3
CVSS Vector: CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N
(at-me in a reply with help or ignore)
| <artifactId>jetty-server</artifactId> | ||
| <version>${version.jetty}</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severe OSS Vulnerability:
pkg:maven/org.eclipse.jetty/jetty-server@9.4.40.v20210413
0 Critical, 1 Severe, 0 Moderate and 0 Unknown vulnerabilities have been found in a transitive dependency of pkg:maven/org.eclipse.jetty/jetty-webapp@9.4.40.v20210413
SEVERE Vulnerabilities (1)
[CVE-2021-28169] For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for r...
For Eclipse Jetty versions <= 9.4.40, <= 10.0.2, <= 11.0.2, it is possible for requests to the ConcatServlet with a doubly encoded path to access protected resources within the WEB-INF directory. For example a request to
/concat?/%2557EB-INF/web.xmlcan retrieve the web.xml file. This can reveal sensitive information regarding the implementation of a web application.CVSS Score: 5.3
CVSS Vector: CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:L/I:N/A:N
(at-me in a reply with help or ignore)
* fastjson from 1.2.75 to 1.2.76 * jackson-databind from 2.12.2 to 2.12.3 * oshi-core from 5.7.0 to 5.7.5 * disruptor from 3.4.2 to 3.4.4 * jacoco-maven-plugin from 0.8.6 to 0.8.7 * version.micrometer from 1.6.5 to 1.6.6 * version.jetty from 9.4.40.v20210413 to 9.4.42.v20210604
N.B. Javalin instances are better not being re-used since previous routes cannot be cleared programmatically (<-> effectively final)
1ba9d10 to
d8f7b11
Compare
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
============================================
+ Coverage 72.49% 72.89% +0.39%
- Complexity 2481 2633 +152
============================================
Files 87 89 +2
Lines 10820 11020 +200
Branches 1652 1719 +67
============================================
+ Hits 7844 8033 +189
+ Misses 2037 2023 -14
- Partials 939 964 +25
Continue to review full report at Codecov.
|
wirew0rm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good, tested command line parameters and Java Properties as well as the MajordomoRestPlugin with the samples and extenal projects and everything seems to be working fine 👍
Bumped sundry library versions:
fixed and added command-line parameter example