Improve handling of blocking builds by adding timeouts #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
============================================
- Coverage 72.35% 72.17% -0.18%
+ Complexity 2472 2463 -9
============================================
Files 87 87
Lines 10821 10821
Branches 1653 1653
============================================
- Hits 7829 7810 -19
- Misses 2044 2065 +21
+ Partials 948 946 -2
Continue to review full report at Codecov.
|
The @timeout annotation of the class is only applied to test methods, not to lifecycle methods like BeforAll/AfterAll. Because of this some tests could block in the lifecycle phases and block the CI.
wirew0rm
force-pushed
the
fixBuildTimeouts
branch
from
e5db2de to
7ad3b7f
Compare
RalphSteinhagen
approved these changes
Mar 31, 2021
Member
RalphSteinhagen
left a comment
RalphSteinhagen
left a comment
There was a problem hiding this comment.
very good as directly discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more timeouts. By default there is no timeout on junit's lifecycle methods and they also do not use the
@Timeoutfrom the class and if they block, the gh actions step will block for the whole 6h and only then report back the cause of the issue.