Add command line interface #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N.B the last being used in unit-tests only
replaced most of the reflection handler and grouped relevant functions in one unit-tested class
RalphSteinhagen
force-pushed
the
addCommandLineInterface
branch
from
40cf073 to
4c8ef08
Compare
RalphSteinhagen
force-pushed
the
addCommandLineInterface
branch
from
df992cc to
693141a
Compare
Member
Author
|
@wirew0rm sorry for force-pushing this ... JDK11/15 CI gave some JavaDoc warnings/errors in the second commit that I wanted to fix locally. Also fixed another time-out optimisation in one of the unit-tests that made the test unnecessary flaky. The core stayed the same though. |
wirew0rm
approved these changes
May 7, 2021
Member
wirew0rm
left a comment
wirew0rm
left a comment
There was a problem hiding this comment.
Looks good +1.
I also removed the remaining getProperty() instances in the server-rest module, please have a look at these and merge if these are ok.
wirew0rm
force-pushed
the
addCommandLineInterface
branch
from
0c6c303 to
f86fdcf
Compare
wirew0rm
force-pushed
the
addCommandLineInterface
branch
from
f86fdcf to
ec87a99
Compare
Replaces the getProperty calls by a RestServerSettings class. Also change the port used by the tests not to be the default port.
wirew0rm
force-pushed
the
addCommandLineInterface
branch
from
ec87a99 to
5aafd09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three little commits (the suggestions is not to squash them):
bump dependencies for fastutil, jmh and oshi-core
N.B the last being used in unit-tests only
refactored ClassFieldDescription and reflection Field handling
added command-line, property, and config-file compatible interface
The latter generically allows the default parameters/settings (i.e. stored as fields in domain-object classes) to be updated based other parameters based on a config-file (lowest priority), the VM environment variables, or the program's command-line arguments. The field parameter may be 'final' and/or 'static' with the exception of 'static final' primitives since these (especially Strings) are likely to be inlined by the JVM. However, unique Strings maybe changed also during run-time (e.g. blanking String that may contain plain-text passwords before behing hashed).
Comments, proposals and improvements are welcome.