Improve MQTT API reference docs#402
Conversation
|
@melissadjadoun As promised in today's meeting, I've fixed the GitHub Actions workflow checks now! |
|
@ethanjli I've made the changes I did to the documentation: I've tried to include all possible error and status messages for each action, along with a description, and also the contents of the imager config metadata file. |
ethanjli
left a comment
There was a problem hiding this comment.
What we have so far is a good start; in this review I've identified various major things which need changes, but I haven't commented on smaller changes needed to make this page clearer and more authoritative - we'll address that in another review after you address the changes I've requested in this review.
Before my next review of this pull request, please compare your documentation page to the draft documentation I had already written in https://docs.google.com/document/d/1BxAlUBMRXEhJkk6OMDVYN7z7l7mky7YTwA_C2Uykrm4/edit#heading=h.fmuu43juukhx , to identify any information I had written there which is still an accurate description the current state of the Python backend (some information may be outdated) but which is missing from your documentation page; and then edit your documentation page to ensure it is not missing that information.
Please also read https://diataxis.fr/reference/ and use that as a writing/style guide as you edit/polish your writing on this page.
documentation/docs/reference/software/interfaces/images/focus_diagram.png
Outdated
Show resolved
Hide resolved
documentation/docs/reference/software/interfaces/images/imager_diagram.png
Outdated
Show resolved
Hide resolved
documentation/docs/reference/software/interfaces/images/pump_diagram.png
Outdated
Show resolved
Hide resolved
documentation/docs/reference/software/interfaces/images/segmenter_diagram.png
Outdated
Show resolved
Hide resolved
|
@ethanjli I've made all the changes you've asked for in the documentation. I've also conducted the tests I could on the remote planktoscope to check the logs. The light part isn't a final version yet, so please let me know if there are any further changes needed. |
|
@melissadjadoun I've reviewed the updated version of the MQTT API documentation, and I:
Can you please edit the other sections of the document to match the structure, formatting, and wording of the "Pump" section as much as possible? For now, please don't edit the headings themselves (i.e. everything in the page's table of contents) - only edit the text under each heading. Also, can you please remove status/error values which are not actually in the code? For example, the |
|
@ethanjli I have edited the other sections of the documentation to match the structure, formatting, and wording of the "Pump" section as closely as possible. I also removed any status/error values that are not actually present in the code. |
|
In my latest commit, I've fixed a bunch of structure/formatting/language inconsistencies and factual errors which you had missed. I think this PR is now good enough to merge; we can open new PRs in the future to fix any remaining errors which I've missed so far. |
this PR updates the MQTT documentation, adding general architecture, json message content explanations for each topic and interval tables to limit value intervals