Show dialog on homepage when config.json's hw version is null#432
Merged
Show dialog on homepage when config.json's hw version is null#432
config.json's hw version is null#432Conversation
5 tasks
Collaborator
Author
|
This PR was approved for merging in the 2024-06-20 software meeting, but with a revision to update the Hardware Settings page's dropdown menu for selecting hardware version after selecting the hardware version from the home page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a prototype for a discussion in the 2024-06-13 software meeting about not setting a default hardware version for the
planktoscopehatbuild of the PlanktoScope OS (reverting a change made in #385) and instead showing a first-time setup dialog on the Node-RED dashboard's homepage prompting the user to select a hardware version; this setup dialog replaces the homepage's buttons (but does not disable the navigation sidebar). Theadafruithatbuild of the PlanktoScope OS will continue to have v2.1 as the default hardware version and thus will not have this dialog.As part of that change, this PR also makes the
planktoscopehatversion of the Node-RED dashboard restart the Python hardware controller whenever the hardware version is changed, whether from the homepage or from the Hardware Settings page. TODO: make this change to theadafruithatversion of the Node-RED dashboard, for consistency.If this PR is combined with #430, then the
fairscope-latestOS image added by #430 will bypass the dialog added by this PR. Note: if this PR is combined with #430, then the hardware version in theplanktoscopehat-latest.config.jsonfile should be set tonull(as done by this PR) instead ofPlanktoScope v2.5(as done by #430).